-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: move policy tax rates to policy key #36784
chore: move policy tax rates to policy key #36784
Conversation
…move-policy-tax-rates-to-policy-key
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In codebase, there are some occurrences of policyTaxRatesOptions
. Can we please rename them to taxRatesOptions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changes looks good and works fine. Thanks!
…move-policy-tax-rates-to-policy-key
@@ -36,28 +36,9 @@ function TaxPicker({selectedTaxRate, policyTaxRates, insets, onSubmit}) { | |||
}, [selectedTaxRate]); | |||
|
|||
const sections = useMemo(() => { | |||
const {policyTaxRatesOptions} = OptionsListUtils.getFilteredOptions( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NAB, this was better readable 😄
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Desktop |
Rodrigo, sorry for the ping |
…move-policy-tax-rates-to-policy-key
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 1.4.44-0 🚀
|
🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.44-13 🚀
|
const defaultTaxKey = taxRates.defaultExternalID; | ||
const defaultTaxName = (defaultTaxKey && `${taxRates.taxes[defaultTaxKey].name} (${taxRates.taxes[defaultTaxKey].value}) • ${translate('common.default')}`) || ''; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we ignore here the foreignTaxDefault
value?
Details
Remove
policyTaxRates_
key and usetaxRates
frompolicy
key.Fixed Issues
$: 36171
PROPOSAL: 36171
Tests
Note:
from step 8, Ensure;
9. Default tax rate and tax amount are selected
10. Tax details are not displayed if tax tracking is disabled
Also, try to edit the tax amount then make sure;
11. that there should be an error when you try to enter a tax amount that is greater than the maximum tax amount.
Offline tests
QA Steps
Note:
from step 8, Ensure;
9. Default tax rate and tax amount are selected
10. Tax details are not displayed if tax tracking is disabled
Also, try to edit the tax amount then make sure;
11. that there should be an error when you try to enter a tax amount that is greater than the maximum tax amount.
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
Screen.Recording.2023-12-17.at.02.38.46.mov
Mobile Web - Chrome
Screen.Recording.2023-12-17.at.03.32.29.mov
Mobile Web - Safari
Screen.Recording.2023-12-17.at.02.45.42.mov
Desktop
Screen.Recording.2023-12-17.at.02.41.46.mov
iOS
Screen.Recording.2023-12-17.at.02.26.37.mov
Android
Screen.Recording.2023-12-17.at.03.28.54.mov